On Wed, Oct 21, 2015 at 1:30 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> And of course we already have these array-clear calls in
>> finish_command().
>>
>> So I agree that deinit helper should exist, but
>>
>> * it should be file-scope static;
>>
>> * it should be called by finish_
Junio C Hamano writes:
> And of course we already have these array-clear calls in
> finish_command().
>
> So I agree that deinit helper should exist, but
>
> * it should be file-scope static;
>
> * it should be called by finish_command(); and
>
> * if you are calling it from collect_finished()
Stefan Beller writes:
> If the `get_next_task` did not explicitly called child_process_init
> and only filled in some fields, there may have been some stale data
> in the child process. This is hard to debug and also adds a review
> burden for each new user of that API. To improve the situation,
Stefan Beller writes:
> If the `get_next_task` did not explicitly called child_process_init
> and only filled in some fields, there may have been some stale data
> in the child process. This is hard to debug and also adds a review
> burden for each new user of that API. To improve the situation,
If the `get_next_task` did not explicitly called child_process_init
and only filled in some fields, there may have been some stale data
in the child process. This is hard to debug and also adds a review
burden for each new user of that API. To improve the situation, we
pass only cleanly initialized
5 matches
Mail list logo
