Re: [PATCH 2/8] pack-objects: produce a stable pack when --skip is given

2016-02-07 Thread Duy Nguyen
On Sat, Feb 6, 2016 at 7:48 AM, Junio C Hamano wrote: >> You noticed that tying the behavior only happens when the user asks >> for it, right? I don't expect people to do resumable fetch/clone by >> default. There are tradeoffs to make and they decide it, we offer >> options. So, it does not reall

Re: [PATCH 2/8] pack-objects: produce a stable pack when --skip is given

2016-02-05 Thread Junio C Hamano
> You noticed that tying the behavior only happens when the user asks > for it, right? I don't expect people to do resumable fetch/clone by > default. There are tradeoffs to make and they decide it, we offer > options. So, it does not really tie our hands in the normal case. You misread me. I do n

Re: [PATCH 2/8] pack-objects: produce a stable pack when --skip is given

2016-02-05 Thread Duy Nguyen
On Sat, Feb 6, 2016 at 1:43 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c >> index 417c830..c58a9cb 100644 >> --- a/builtin/pack-objects.c >> +++ b/builtin/pack-objects.c >> @@ -2709,6 +2709,11 @@ int cmd_pack_objects(i

Re: [PATCH 2/8] pack-objects: produce a stable pack when --skip is given

2016-02-05 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c > index 417c830..c58a9cb 100644 > --- a/builtin/pack-objects.c > +++ b/builtin/pack-objects.c > @@ -2709,6 +2709,11 @@ int cmd_pack_objects(int argc, const char **argv, > const char *prefix) >

[PATCH 2/8] pack-objects: produce a stable pack when --skip is given

2016-02-05 Thread Nguyễn Thái Ngọc Duy
Parallel delta search does not produce a stable pack so it's disabled when --skip is used. zlib compression algorithm is stable. Ref negotiation should be stable (at least on smart http). Ref changes will be addressed separately. So unless configuration files or git binary is changed, we should be