Re: [PATCH 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-14 Thread John Keeping
On Mon, Jan 14, 2013 at 05:48:18AM +0100, Michael Haggerty wrote: > On 01/13/2013 05:17 PM, John Keeping wrote: >> On Sun, Jan 13, 2013 at 04:26:39AM +0100, Michael Haggerty wrote: >>> On 01/12/2013 08:23 PM, John Keeping wrote: Although 2to3 will fix most issues in Python 2 code to make it ru

Re: [PATCH 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-13 Thread Michael Haggerty
On 01/13/2013 05:17 PM, John Keeping wrote: > On Sun, Jan 13, 2013 at 04:26:39AM +0100, Michael Haggerty wrote: >> On 01/12/2013 08:23 PM, John Keeping wrote: >>> Although 2to3 will fix most issues in Python 2 code to make it run under >>> Python 3, it does not handle the new strict separation betw

Re: [PATCH 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-13 Thread John Keeping
On Sun, Jan 13, 2013 at 04:26:39AM +0100, Michael Haggerty wrote: > On 01/12/2013 08:23 PM, John Keeping wrote: >> Although 2to3 will fix most issues in Python 2 code to make it run under >> Python 3, it does not handle the new strict separation between byte >> strings and unicode strings. There i

Re: [PATCH 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-12 Thread Michael Haggerty
On 01/12/2013 08:23 PM, John Keeping wrote: > Although 2to3 will fix most issues in Python 2 code to make it run under > Python 3, it does not handle the new strict separation between byte > strings and unicode strings. There is one instance in > git_remote_helpers where we are caught by this. >

[PATCH 2/8] git_remote_helpers: fix input when running under Python 3

2013-01-12 Thread John Keeping
Although 2to3 will fix most issues in Python 2 code to make it run under Python 3, it does not handle the new strict separation between byte strings and unicode strings. There is one instance in git_remote_helpers where we are caught by this. Fix it by explicitly decoding the incoming byte string