Re: [PATCH 2/5] run-command: teach async threads to ignore SIGPIPE

2016-04-20 Thread Jeff King
On Thu, Apr 21, 2016 at 07:15:26AM +0200, Johannes Sixt wrote: > Am 20.04.2016 um 00:49 schrieb Jeff King: > >This is our first use of pthread_sigmask, and I think Windows will have > >to come up with something for this in compat/. I don't know how SIGPIPE > >works there at all, so it's possible t

Re: [PATCH 2/5] run-command: teach async threads to ignore SIGPIPE

2016-04-20 Thread Johannes Sixt
Am 20.04.2016 um 00:49 schrieb Jeff King: This is our first use of pthread_sigmask, and I think Windows will have to come up with something for this in compat/. I don't know how SIGPIPE works there at all, so it's possible that we can just turn this into a noop. Worst case it could probably block

[PATCH 2/5] run-command: teach async threads to ignore SIGPIPE

2016-04-19 Thread Jeff King
Async processes can be implemented as separate forked processes, or as threads (depending on the NO_PTHREADS setting). In the latter case, if an async thread gets SIGPIPE, it takes down the whole process. This is obviously bad if the main process was not otherwise going to die, but even if we were