Re: [PATCH 2/5] mergetool: use get_merge_tool function

2019-04-22 Thread Denton Liu
Hi Eric, On Mon, Apr 22, 2019 at 03:07:25AM -0400, Eric Sunshine wrote: > On Mon, Apr 22, 2019 at 1:07 AM Denton Liu wrote: > > [...] > > Rewrite `get_merge_tool` to return whether or not the tool was guessed > > and make git-mergetool call this function instead of duplicating the > > logic. Also

Re: [PATCH 2/5] mergetool: use get_merge_tool function

2019-04-22 Thread Eric Sunshine
On Mon, Apr 22, 2019 at 1:07 AM Denton Liu wrote: > [...] > Rewrite `get_merge_tool` to return whether or not the tool was guessed > and make git-mergetool call this function instead of duplicating the > logic. Also, let `$GIT_MERGETOOL_GUI` be set to determine whether or not > the guitool will be

[PATCH 2/5] mergetool: use get_merge_tool function

2019-04-21 Thread Denton Liu
In git-mergetool, the logic for getting which merge tool to use is duplicated in git-mergetool--lib, except for the fact that it needs to know whether the tool was guessed or not. Rewrite `get_merge_tool` to return whether or not the tool was guessed and make git-mergetool call this function inste