Re: [PATCH 2/5] gc: convert to using the_hash_algo

2019-03-13 Thread Jeff King
On Thu, Mar 14, 2019 at 12:54:36AM +0100, Ævar Arnfjörð Bjarmason wrote: > There's been a lot of changing of the hardcoded "40" values to > the_hash_algo->hexsz, but we've so far missed this one where we > hardcoded 38 for the loose object file length. > > This is because a SHA-1 like abcde[...]

[PATCH 2/5] gc: convert to using the_hash_algo

2019-03-13 Thread Ævar Arnfjörð Bjarmason
There's been a lot of changing of the hardcoded "40" values to the_hash_algo->hexsz, but we've so far missed this one where we hardcoded 38 for the loose object file length. This is because a SHA-1 like abcde[...] gets turned into objects/ab/cde[...]. There's no reason to suppose the same won't be