Re: [PATCH 2/5] common-main: call git_extract_argv0_path()

2016-07-01 Thread Johannes Schindelin
Hi Peff, On Fri, 1 Jul 2016, Jeff King wrote: > This has been an accident-waiting-to-happen for a long time, > but wasn't triggered until recently because it involves one > of those programs actually calling system_path(). That > happened with git-credential-store in v2.8.0 with ae5f677 > (lazily

[PATCH 2/5] common-main: call git_extract_argv0_path()

2016-06-30 Thread Jeff King
Every program which links against libgit.a must call this function, or risk hitting an assert() in system_path() that checks whether we have configured argv0_path (though only when RUNTIME_PREFIX is defined, so essentially only on Windows). Looking at the diff, you can see that putting it into the