Re: [PATCH 2/4] submodule-config: keep groups around

2016-01-20 Thread Junio C Hamano
Stefan Beller writes: > In this patch series we only need to check the items of that list one by one, > no need for a sorted version, so I'll change it to be unsorted and > document that. I actually was going to suggest keeping the sorted one. The order may be changed from the order specified i

Re: [PATCH 2/4] submodule-config: keep groups around

2016-01-20 Thread Stefan Beller
On Wed, Jan 20, 2016 at 1:23 PM, Junio C Hamano wrote: >> free((void *) entry->config->name); >> + if (entry->config->groups) >> + string_list_clear(entry->config->groups, 0); > > You are allocating entry->config->groups itself in the in the hunk > around ll.327, so that also

Re: [PATCH 2/4] submodule-config: keep groups around

2016-01-20 Thread Junio C Hamano
Stefan Beller writes: > We need the submodule groups in a later patch. > > Signed-off-by: Stefan Beller > --- > submodule-config.c | 13 + > submodule-config.h | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/submodule-config.c b/submodule-config.c > index a32259e..b5453