Re: [PATCH 2/4] submodule--helper clone: simplify path check

2016-03-31 Thread Stefan Beller
On Thu, Mar 31, 2016 at 12:31 AM, Eric Sunshine wrote: > On Wed, Mar 30, 2016 at 8:17 PM, Stefan Beller wrote: >> The calling shell code makes sure that `path` is non null and non empty. >> (side note: it cannot be null as just three lines before it is passed >> to safe_create_leading_directories

Re: [PATCH 2/4] submodule--helper clone: simplify path check

2016-03-31 Thread Eric Sunshine
On Thu, Mar 31, 2016 at 12:36 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> The calling shell code makes sure that `path` is non null and non empty. >> (side note: it cannot be null as just three lines before it is passed >> to safe_create_leading_directories_const which would crash as y

Re: [PATCH 2/4] submodule--helper clone: simplify path check

2016-03-31 Thread Junio C Hamano
Stefan Beller writes: > The calling shell code makes sure that `path` is non null and non empty. > (side note: it cannot be null as just three lines before it is passed > to safe_create_leading_directories_const which would crash as you feed > it null). This is not Java so let's spell that thing

Re: [PATCH 2/4] submodule--helper clone: simplify path check

2016-03-31 Thread Eric Sunshine
On Wed, Mar 30, 2016 at 8:17 PM, Stefan Beller wrote: > The calling shell code makes sure that `path` is non null and non empty. > (side note: it cannot be null as just three lines before it is passed > to safe_create_leading_directories_const which would crash as you feed > it null). I'm confuse

Re: [PATCH 2/4] submodule--helper clone: simplify path check

2016-03-30 Thread Jacob Keller
On Wed, Mar 30, 2016 at 5:17 PM, Stefan Beller wrote: > The calling shell code makes sure that `path` is non null and non empty. > (side note: it cannot be null as just three lines before it is passed > to safe_create_leading_directories_const which would crash as you feed > it null). > So we're

[PATCH 2/4] submodule--helper clone: simplify path check

2016-03-30 Thread Stefan Beller
The calling shell code makes sure that `path` is non null and non empty. (side note: it cannot be null as just three lines before it is passed to safe_create_leading_directories_const which would crash as you feed it null). Signed-off-by: Stefan Beller --- builtin/submodule--helper.c | 5 +