Re: [PATCH 2/3] t7406: fix here-doc syntax errors

2017-03-22 Thread Jeff King
On Wed, Mar 22, 2017 at 02:32:22PM -0700, Stefan Beller wrote: > > But the submodule path seems wrong, too. I'm not sure if > > the expectation is wrong, or if there's a bug. +cc Stefan > > Yes the actual output is wrong, too. > But that is not because Git is wrong, but the test suite is. > >

Re: [PATCH 2/3] t7406: fix here-doc syntax errors

2017-03-22 Thread Junio C Hamano
Jeff King writes: > After applying this, I get a failure: > > --- expect 2017-03-22 21:01:53.350721155 + > +++ actual 2017-03-22 21:01:53.346721155 + > @@ -1 +1 @@ > -Execution of 'false $submodulesha1' failed in submodule path 'submodule' > +Execution of 'false 4301fd3e4110d3

Re: [PATCH 2/3] t7406: fix here-doc syntax errors

2017-03-22 Thread Stefan Beller
On Wed, Mar 22, 2017 at 2:07 PM, Jeff King wrote: > On Wed, Mar 22, 2017 at 01:08:04PM -0700, Junio C Hamano wrote: > >> diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh >> index 347857fa7c..a20df9420a 100755 >> --- a/t/t7406-submodule-update.sh >> +++ b/t/t7406-submodule-upd

Re: [PATCH 2/3] t7406: fix here-doc syntax errors

2017-03-22 Thread Jeff King
On Wed, Mar 22, 2017 at 01:08:04PM -0700, Junio C Hamano wrote: > diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh > index 347857fa7c..a20df9420a 100755 > --- a/t/t7406-submodule-update.sh > +++ b/t/t7406-submodule-update.sh > @@ -442,9 +442,9 @@ test_expect_success 'submodul

[PATCH 2/3] t7406: fix here-doc syntax errors

2017-03-22 Thread Junio C Hamano
From: Jan Palus The came in an earlier sb/submodule-update-initial-runs-custom-script topic that was merged to 2.12. Signed-off-by: Junio C Hamano --- * This should be applied on top of e7b37caf ("submodule update: run custom update script for initial populating as well", 2017-01-25) t/t