Re: [PATCH 2/3] gitweb: Add a feature for adding more branch refs

2013-12-04 Thread Junio C Hamano
Krzesimir Nowak writes: > On Tue, 2013-12-03 at 21:38 +0100, Jakub Narębski wrote: >> On Tue, Dec 3, 2013 at 9:15 PM, Junio C Hamano wrote: >> > Krzesimir Nowak writes: >> > >> >> @@ -626,6 +640,17 @@ sub feature_avatar { >> >> return @val ? @val : @_; >> >> } >> >> >> >> +sub feature_ex

Re: [PATCH 2/3] gitweb: Add a feature for adding more branch refs

2013-12-04 Thread Krzesimir Nowak
On Tue, 2013-12-03 at 21:38 +0100, Jakub Narębski wrote: > On Tue, Dec 3, 2013 at 9:15 PM, Junio C Hamano wrote: > > Krzesimir Nowak writes: > > > >> @@ -626,6 +640,17 @@ sub feature_avatar { > >> return @val ? @val : @_; > >> } > >> > >> +sub feature_extra_branch_refs { > >> + my (@br

Re: [PATCH 2/3] gitweb: Add a feature for adding more branch refs

2013-12-03 Thread Jakub Narębski
On Tue, Dec 3, 2013 at 9:15 PM, Junio C Hamano wrote: > Krzesimir Nowak writes: > >> @@ -626,6 +640,17 @@ sub feature_avatar { >> return @val ? @val : @_; >> } >> >> +sub feature_extra_branch_refs { >> + my (@branch_refs) = @_; >> + my $values = git_get_project_config('extra_branch

Re: [PATCH 2/3] gitweb: Add a feature for adding more branch refs

2013-12-03 Thread Junio C Hamano
Krzesimir Nowak writes: > @@ -626,6 +640,17 @@ sub feature_avatar { > return @val ? @val : @_; > } > > +sub feature_extra_branch_refs { > + my (@branch_refs) = @_; > + my $values = git_get_project_config('extra_branch_refs'); Hmph. Three points. * Almost all callers of this fu

Re: [PATCH 2/3] gitweb: Add a feature for adding more branch refs

2013-12-03 Thread Junio C Hamano
Krzesimir Nowak writes: > Allow extra-branch-refs feature to tell gitweb to show refs from > additional hierarchies in addition to branches in the list-of-branches > view. > > Signed-off-by: Krzesimir Nowak > Reviewed-by: Junio C Hamano Please do not add "Reviewed-by:" like this; I've never re

[PATCH 2/3] gitweb: Add a feature for adding more branch refs

2013-12-03 Thread Krzesimir Nowak
Allow extra-branch-refs feature to tell gitweb to show refs from additional hierarchies in addition to branches in the list-of-branches view. Signed-off-by: Krzesimir Nowak Reviewed-by: Junio C Hamano Reviewed-by: Jakub Narębski Reviewed-by: Eric Sunshine --- Documentation/gitweb.conf.txt | 2