Re: [PATCH 2/3] check_replace_refs: rename to read_replace_refs

2018-07-18 Thread Jeff King
On Wed, Jul 18, 2018 at 03:44:36PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > This was added as a NEEDSWORK in 3c36d7de2 (replace-object: > > I'll do s/3c36d7de2/c&/; while queuing. Oops, vi strikes again, I think. > Like you, I do not think one is vastly better than the other bet

Re: [PATCH 2/3] check_replace_refs: rename to read_replace_refs

2018-07-18 Thread Junio C Hamano
Jeff King writes: > This was added as a NEEDSWORK in 3c36d7de2 (replace-object: I'll do s/3c36d7de2/c&/; while queuing. Like you, I do not think one is vastly better than the other between these two names, but since a patch has been written, so ... > check_replace_refs is safe in multi repo en

[PATCH 2/3] check_replace_refs: rename to read_replace_refs

2018-07-18 Thread Jeff King
This was added as a NEEDSWORK in 3c36d7de2 (replace-object: check_replace_refs is safe in multi repo environment, 2018-04-11), waiting for a calmer period. Since doing so now doesn't conflict with anything in 'pu', it seems as good a time as any. Signed-off-by: Jeff King --- builtin/fsck.c