Re: [PATCH 2/3] bisect: fix internal diff-tree config loading

On Sun, Mar 03, 2019 at 06:59:19PM +0100, Christian Couder wrote: > On Fri, Feb 22, 2019 at 7:21 AM Jeff King wrote: > > > > When we run our internal diff-tree to show the bisected commit, we call > > init_revisions(), then load config, then setup_revisions(). But that > > order is wrong: we copy

Re: [PATCH 2/3] bisect: fix internal diff-tree config loading

On Fri, Feb 22, 2019 at 7:21 AM Jeff King wrote: > > When we run our internal diff-tree to show the bisected commit, we call > init_revisions(), then load config, then setup_revisions(). But that > order is wrong: we copy the configured defaults into the rev_info struct > during the init_revisions

[PATCH 2/3] bisect: fix internal diff-tree config loading

When we run our internal diff-tree to show the bisected commit, we call init_revisions(), then load config, then setup_revisions(). But that order is wrong: we copy the configured defaults into the rev_info struct during the init_revisions step, so our config load wasn't actually doing anything. S