Re: [PATCH 2/2] test-config: Add tests for the config_set API

2014-07-02 Thread Tanay Abhra
On 7/2/2014 2:59 PM, Matthieu Moy wrote: > Tanay Abhra writes: > >> +test_expect_success 'clear default config' ' >> +rm -f .git/config >> +' >> + >> +cat > .git/config << EOF > > t/README says: > > - Put all code inside test_expect_success and other assertions. > >Even code that is

Re: [PATCH 2/2] test-config: Add tests for the config_set API

2014-07-02 Thread Matthieu Moy
Tanay Abhra writes: > +test_expect_success 'clear default config' ' > + rm -f .git/config > +' > + > +cat > .git/config << EOF t/README says: - Put all code inside test_expect_success and other assertions. Even code that isn't a test per se, but merely some setup code should be insi

[PATCH 2/2] test-config: Add tests for the config_set API

2014-07-01 Thread Tanay Abhra
Expose the `config_set` C API as a set of simple commands in order to facilitate testing. Add tests for the `config_set` API as well as for `git_config_get_*()` family for the usual config files. Signed-off-by: Tanay Abhra --- .gitignore | 1 + Makefile | 1 + t/t13