Re: [PATCH 2/2] rm: re-use parse_pathspec's trailing-slash removal

2013-09-11 Thread John Keeping
On Wed, Sep 11, 2013 at 02:48:51PM +0700, Duy Nguyen wrote: > On Wed, Sep 11, 2013 at 2:13 AM, John Keeping wrote: > > Instead of re-implementing the "remove trailing slashes" loop in > > builtin/rm.c just pass PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP to > > parse_pathspec. > > > > Signed-off-by: John

Re: [PATCH 2/2] rm: re-use parse_pathspec's trailing-slash removal

2013-09-11 Thread Duy Nguyen
On Wed, Sep 11, 2013 at 2:13 AM, John Keeping wrote: > Instead of re-implementing the "remove trailing slashes" loop in > builtin/rm.c just pass PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP to > parse_pathspec. > > Signed-off-by: John Keeping > --- > builtin/rm.c | 20 > 1 file chan

[PATCH 2/2] rm: re-use parse_pathspec's trailing-slash removal

2013-09-10 Thread John Keeping
Instead of re-implementing the "remove trailing slashes" loop in builtin/rm.c just pass PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP to parse_pathspec. Signed-off-by: John Keeping --- builtin/rm.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/builtin/rm.c b/bu