Re: [PATCH 2/2] perf-lib: add test_perf_cleanup target

2013-09-20 Thread Thomas Gummerer
Junio C Hamano writes: > Junio C Hamano writes: > >> Thomas Gummerer writes: >> >>> When one performance test fails, the testing is aborted and the cleanup >>> commands are not executed anymore, leaving the trash directory in the >>> failed state. >> >> Ah, that I overlooked. In that case, the

Re: [PATCH 2/2] perf-lib: add test_perf_cleanup target

2013-09-19 Thread Junio C Hamano
Junio C Hamano writes: > Thomas Gummerer writes: > >> When one performance test fails, the testing is aborted and the cleanup >> commands are not executed anymore, leaving the trash directory in the >> failed state. > > Ah, that I overlooked. In that case, the comments in my previous > message d

Re: [PATCH 2/2] perf-lib: add test_perf_cleanup target

2013-09-19 Thread Junio C Hamano
Junio C Hamano writes: > I wondered why this clean-up section cannot be an optional parameter > to test_perf, but that would not fly well because we won't know if > 3-arg form is with one prerequisite and no clean-up, or no prereq > with a clean-up, so perhaps adding a new function may be the bes

Re: [PATCH 2/2] perf-lib: add test_perf_cleanup target

2013-09-19 Thread Junio C Hamano
Thomas Gummerer writes: > When one performance test fails, the testing is aborted and the cleanup > commands are not executed anymore, leaving the trash directory in the > failed state. Ah, that I overlooked. In that case, the comments in my previous message do not apply. Thanks. -- To unsubsc

Re: [PATCH 2/2] perf-lib: add test_perf_cleanup target

2013-09-19 Thread Thomas Gummerer
Junio C Hamano writes: > Thomas Gummerer writes: > >> +For performance tests that need cleaning up after them that should not >> +be timed, use >> + >> +test_perf_cleanup 'descriptive string' ' >> +command1 && >> +command2 >> +' ' >> +cleanupcommand1 &

Re: [PATCH 2/2] perf-lib: add test_perf_cleanup target

2013-09-17 Thread Junio C Hamano
Thomas Gummerer writes: > +For performance tests that need cleaning up after them that should not > +be timed, use > + > + test_perf_cleanup 'descriptive string' ' > + command1 && > + command2 > + ' ' > + cleanupcommand1 && > + cleanupcomman

[PATCH 2/2] perf-lib: add test_perf_cleanup target

2013-09-17 Thread Thomas Gummerer
Currently there is no way to clean up the changes that have been made with test_perf for the next run. Add a way to reset the repository to the state before the test for testing commands that modify the git repository, e.g. for perf testing git add. Signed-off-by: Thomas Gummerer --- This enabl