Re: [PATCH 2/2] ls-files: add pathspec matching for submodules

2016-09-21 Thread Brandon Williams
On Wed, Sep 21, 2016 at 3:53 PM, Junio C Hamano wrote: > > Sounds sensible. Just a minor nit in terminology, but I think we > fairly consistently say "a superproject contains submodules" (run > "git grep -E 'super *(module|project)'"). > > I'd suggest s/super module/superproject/ for consistency.

Re: [PATCH 2/2] ls-files: add pathspec matching for submodules

2016-09-21 Thread Junio C Hamano
Brandon Williams writes: > Pathspecs can be a bit tricky when trying to apply them to submodules. > The main challenge is that the pathspecs will be with respect to the > super module and not with respect to paths in the submodule. The > approach this patch takes is to pass in the identical path

[PATCH 2/2] ls-files: add pathspec matching for submodules

2016-09-21 Thread Brandon Williams
Pathspecs can be a bit tricky when trying to apply them to submodules. The main challenge is that the pathspecs will be with respect to the super module and not with respect to paths in the submodule. The approach this patch takes is to pass in the identical pathspec from the super module to the s