Re: [PATCH 2/2] git-svn: test for git-svn prefixed globs

2015-12-16 Thread Eric Wong
Victor Leschuk wrote: > Hello Eric, sorry, I just copy pasted your old > t9108-git-svn-glob.sh, changed branch names to be prefixed and added > test for "exact" prefix match. If it is necessary I can rewrite it > according to current guidelines. Yes, please do if you can. I can do it if you're w

Re: [PATCH 2/2] git-svn: test for git-svn prefixed globs

2015-12-16 Thread Victor Leschuk
Hello Eric, sorry, I just copy pasted your old t9108-git-svn-glob.sh, changed branch names to be prefixed and added test for "exact" prefix match. If it is necessary I can rewrite it according to current guidelines. On 12/17/2015 12:28 AM, Eric Wong wrote: Thanks for this work. Most things lo

Re: [PATCH 2/2] git-svn: test for git-svn prefixed globs

2015-12-16 Thread Eric Wong
Thanks for this work. Most things look fine with 1/2, comments on 2/2 below... Victor Leschuk wrote: > Add test for git-svn prefixed globs. Why a separate patch? Unless there's some documentation purpose for a regression, usually tests and a feature should be added atomically in the same commi

[PATCH 2/2] git-svn: test for git-svn prefixed globs

2015-12-16 Thread Victor Leschuk
Add test for git-svn prefixed globs. Signed-off-by: Victor Leschuk --- t/t9168-git-svn-prefixed-glob.sh | 136 +++ 1 file changed, 136 insertions(+) create mode 100755 t/t9168-git-svn-prefixed-glob.sh diff --git a/t/t9168-git-svn-prefixed-glob.sh b/t/t9168-g