Re: [PATCH 2/2] config.c: handle lock file in error case in git_config_rename_...

2016-12-20 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > We could rely on atexit() to clean up everything, but let's be > explicit when we can. And it's good anyway because the function is > called the second time in the same process, we're in trouble. > > This function should not affect the successful case because after

[PATCH 2/2] config.c: handle lock file in error case in git_config_rename_...

2016-12-20 Thread Nguyễn Thái Ngọc Duy
We could rely on atexit() to clean up everything, but let's be explicit when we can. And it's good anyway because the function is called the second time in the same process, we're in trouble. This function should not affect the successful case because after commit_lock_file() is called, rollback_l