Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Johannes Sixt
Am 27.04.2014 18:46, schrieb Marius Ungureanu: > Is it okay though if I add a few tests to show what is broken? > > I think this can’t be solved at a regex level. It's OK to add tests that show breakages even if there is no immediate solution. >> You can mark a userdiff test case that demonstrat

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Marius Ungureanu
> You can mark a userdiff test case that demonstrates a breakage by > including the work "broken" somewhere in the file. See > http://www.repo.or.cz/w/alt-git.git/commitdiff/9cc444f0570b196f1c51664ce2de1d8e1dee6046 > -- Hannes Would you like me to add tests first, then fix them? Or just like this

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Marius Ungureanu
On 27 Apr 2014, at 19:19, Johannes Sixt wrote: > Am 27.04.2014 15:47, schrieb Marius Ungureanu: >> >> --- > > Thanks. Please signed off your patch. > Ah, yes, forgot to do that. > When you re-send, please place [PATCH v3 n/m] in the subject (and drop > the "Re:") and note what you changed c

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Johannes Sixt
Am 27.04.2014 15:47, schrieb Marius Ungureanu: > > --- Thanks. Please signed off your patch. When you re-send, please place [PATCH v3 n/m] in the subject (and drop the "Re:") and note what you changed compared to the previous (or all earlier) rounds. The place for this note is here, after the "-

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Marius Ungureanu
Ugh, there’s an empty line at the beginning of the 2nd patch that shouldn’t be there. Thanks, Marius-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] add csharp userdiff tests

2014-04-27 Thread Marius Ungureanu
--- t/t4018/csharp-constructor | 4 t/t4018/csharp-destructor | 4 t/t4018/csharp-function| 4 t/t4018/csharp-member | 4 t/t4018/csharp-namespace | 4 t/t4018/csharp-operator| 4 t/t4018/csharp-property| 4 t/t4018/csharp-skip-call | 5 +++