Re: [PATCH 2/2] Setup working tree in describe

2019-01-26 Thread Jeff King
On Sat, Jan 26, 2019 at 03:07:54PM +0100, Sebastian Staudt wrote: > Are you sure that it will fail without a working tree? > Is it even possible to have *no* working tree? > > I already tested this with some real life examples, e.g. > > git --git-dir /some/path/.git describe > > From inside

Re: [PATCH 2/2] Setup working tree in describe

2019-01-26 Thread Sebastian Staudt
Am Sa., 26. Jan. 2019 um 12:01 Uhr schrieb Duy Nguyen : > > On Sat, Jan 26, 2019 at 5:44 PM Sebastian Staudt wrote: > > > > This ensures the given working tree is used for --dirty and --broken. > > > > Signed-off-by: Sebastian Staudt > > --- > > builtin/describe.c | 2 ++ > > 1 file changed, 2 i

Re: [PATCH 2/2] Setup working tree in describe

2019-01-26 Thread Duy Nguyen
On Sat, Jan 26, 2019 at 5:44 PM Sebastian Staudt wrote: > > This ensures the given working tree is used for --dirty and --broken. > > Signed-off-by: Sebastian Staudt > --- > builtin/describe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/builtin/describe.c b/builtin/describe.c > in

[PATCH 2/2] Setup working tree in describe

2019-01-26 Thread Sebastian Staudt
This ensures the given working tree is used for --dirty and --broken. Signed-off-by: Sebastian Staudt --- builtin/describe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/describe.c b/builtin/describe.c index cc118448ee..ba1a0b199b 100644 --- a/builtin/describe.c +++ b/builtin/de