Re: [PATCH 2/2] Have the diff-* builtins configure diff before initializing revisions.

2017-04-30 Thread Jeff King
On Mon, May 01, 2017 at 01:17:58AM -0400, Jeff King wrote: > Yeah, I agree it is an existing bug. The only other case I found is > dirstat. Doing: > > mkdir a b > for i in 1 2; do echo content >a/$i; done > for i in 1 2 3; do echo content >b/$i; done > git -c diff.dirstat=50 diff-tree --d

Re: [PATCH 2/2] Have the diff-* builtins configure diff before initializing revisions.

2017-04-30 Thread Jeff King
On Sun, Apr 30, 2017 at 06:01:37PM -0700, Junio C Hamano wrote: > >> + git_config(git_diff_basic_config, NULL); /* no "diff" UI options */ > >>init_revisions(&rev, prefix); > >>gitmodules_config(); > >> - git_config(git_diff_basic_config, NULL); /* no "diff" UI options */ > >>rev.abb

Re: [PATCH 2/2] Have the diff-* builtins configure diff before initializing revisions.

2017-04-30 Thread Junio C Hamano
Jeff King writes: > On Thu, Apr 27, 2017 at 04:50:37PM -0400, Marc Branchaud wrote: > >> Subject: [PATCH 2/2] Have the diff-* builtins configure diff before >> initializing revisions. >> >> This makes the commands respect diff configuration options, such as >>

Re: [PATCH 2/2] Have the diff-* builtins configure diff before initializing revisions.

2017-04-28 Thread Jeff King
On Thu, Apr 27, 2017 at 04:50:37PM -0400, Marc Branchaud wrote: > Subject: [PATCH 2/2] Have the diff-* builtins configure diff before > initializing revisions. > > This makes the commands respect diff configuration options, such as > indentHeuristic. > > Signed-off-by: Mar

[PATCH 2/2] Have the diff-* builtins configure diff before initializing revisions.

2017-04-27 Thread Marc Branchaud
This makes the commands respect diff configuration options, such as indentHeuristic. Signed-off-by: Marc Branchaud --- builtin/diff-files.c | 2 +- builtin/diff-index.c | 2 +- builtin/diff-tree.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/diff-files.c b/buil