Re: [PATCH 2/2] Fix stack-use-after-scope error reported by ASAN by GCC 7.

2017-04-06 Thread Johannes Schindelin
Hi Martin, On Thu, 6 Apr 2017, Martin Liška wrote: > Following patch fixes issues that can be seen with -fsanitize=address on > GCC 7. Good catch. However, it may make more sense to switch to using the "args" field instead of the "argv" field: it is of type "struct argv_array" and is released a

Re: [PATCH 2/2] Fix stack-use-after-scope error reported by ASAN by GCC 7.

2017-04-06 Thread Jeff King
On Thu, Apr 06, 2017 at 10:02:45AM +0200, Martin Liška wrote: > Subject: [PATCH 2/2] Fix stack-use-after-scope error reported by ASAN by GCC > 7. > > The use-after-scope is triggered here: > READ of size 8 at 0x7ffc4f674e20 thread T0 > #0 0x6f0b69 in finish_comma

[PATCH 2/2] Fix stack-use-after-scope error reported by ASAN by GCC 7.

2017-04-06 Thread Martin Liška
use-after-scope error reported by ASAN by GCC 7. The use-after-scope is triggered here: READ of size 8 at 0x7ffc4f674e20 thread T0 #0 0x6f0b69 in finish_command /home/marxin/Programming/git/run-command.c:570 #1 0x5b6101 in kill_multi_file_filter /home/marxin/Programming/git/convert.c:570