Re: [PATCH 2/2][GSoC 2014] diff: used is_dot_or_dotdot() in code

2014-03-18 Thread Eric Sunshine
On Tue, Mar 18, 2014 at 11:58 PM, Brian Bourn wrote: > On Tue, Mar 18, 2014 at 11:45 PM, Eric Sunshine > wrote: >> On Tue, Mar 18, 2014 at 9:30 PM, babourn wrote: >> > Subject: diff: used is_dot_or_dotdot() in code >> > Signed-off-by: Brian Bourn >> > --- >> > diff-no-index.c | 2 +- >> > 1 fi

Re: [PATCH 2/2][GSoC 2014] diff: used is_dot_or_dotdot() in code

2014-03-18 Thread Eric Sunshine
On Tue, Mar 18, 2014 at 9:30 PM, babourn wrote: > Subject: diff: used is_dot_or_dotdot() in code Use imperative voice: "use" rather than "used" > in accordance with the GSoC Microproject implemented This commentary will not have much meaning to someone reading the commit log months or years fro

[PATCH 2/2][GSoC 2014] diff: used is_dot_or_dotdot() in code

2014-03-18 Thread babourn
in accordance with the GSoC Microproject implemented the call is_dot_or_dotdot() in the code in order to further universalize the call to the function and increase code continuity. Signed-off-by: Brian Bourn ---  diff-no-index.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/