Re: [PATCH 17/67] use xsnprintf for generating git object headers

2015-09-16 Thread Junio C Hamano
Jeff King writes: > We generally use 32-byte buffers to format git's "type size" > header fields. These should not generally overflow unless > you can produce some truly gigantic objects (and our types > come from our internal array of constant strings). But it is > a good idea to use xsnprintf t

[PATCH 17/67] use xsnprintf for generating git object headers

2015-09-15 Thread Jeff King
We generally use 32-byte buffers to format git's "type size" header fields. These should not generally overflow unless you can produce some truly gigantic objects (and our types come from our internal array of constant strings). But it is a good idea to use xsnprintf to make sure this is the case.