Re: [PATCH 14/14] verify-commit: simplify parameters to run_gpg_verify()

2019-05-10 Thread Derrick Stolee
On 5/9/2019 5:32 PM, Jeff King wrote: > Instead, let's do our type check by loading the object via > parse_object(). That will attach the buffer to the struct so it can be > used later by check_commit_signature(). And it ensures that > lookup_commit() will return something sane. This is a good ide

[PATCH 14/14] verify-commit: simplify parameters to run_gpg_verify()

2019-05-09 Thread Jeff King
The buf/len parameters of run_gpg_verify() have never been used since the function was added in d07b00b7f3 (verify-commit: scriptable commit signature verification, 2014-06-23). Instead, check_commit_signature() accesses the commit struct directly. Worse, we read the whole object just to check its