Re: [PATCH 13/14] git-compat-util.h: fix integer overflow on IL32P64 systems

2014-10-09 Thread Junio C Hamano
Marat Radchenko writes: > On Wed, Oct 08, 2014 at 01:02:10PM -0700, Junio C Hamano wrote: >> Junio C Hamano writes: >> >> > Marat Radchenko writes: >> > >> >> Signed-off-by: Marat Radchenko >> >> --- >> >> git-compat-util.h | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >>

Re: [msysGit] Re: [PATCH 13/14] git-compat-util.h: fix integer overflow on IL32P64 systems

2014-10-08 Thread Johannes Schindelin
Hi Junio, On Wed, 8 Oct 2014, Junio C Hamano wrote: > Marat Radchenko writes: > > > #define DEFAULT_PACKED_GIT_LIMIT \ > > - ((1024L * 1024L) * (sizeof(void*) >= 8 ? 8192 : 256)) > > + ((size_t)(1024L * 1024L) * (sizeof(void*) >= 8 ? 8192 : 256)) > > 1024 * 1024 * 8192 overflows 32-bit un

Re: [PATCH 13/14] git-compat-util.h: fix integer overflow on IL32P64 systems

2014-10-08 Thread Marat Radchenko
On Wed, Oct 08, 2014 at 01:02:10PM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > Marat Radchenko writes: > > > >> Signed-off-by: Marat Radchenko > >> --- > >> git-compat-util.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/git-compat-util.h b/g

Re: [PATCH 13/14] git-compat-util.h: fix integer overflow on IL32P64 systems

2014-10-08 Thread Junio C Hamano
Junio C Hamano writes: > Marat Radchenko writes: > >> Signed-off-by: Marat Radchenko >> --- >> git-compat-util.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/git-compat-util.h b/git-compat-util.h >> index b338277..101c9d7 100644 >> --- a/git-compat-util.h >> +++

Re: [PATCH 13/14] git-compat-util.h: fix integer overflow on IL32P64 systems

2014-10-08 Thread Junio C Hamano
Marat Radchenko writes: > Signed-off-by: Marat Radchenko > --- > git-compat-util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/git-compat-util.h b/git-compat-util.h > index b338277..101c9d7 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -474,7 +474,

[PATCH 13/14] git-compat-util.h: fix integer overflow on IL32P64 systems

2014-10-08 Thread Marat Radchenko
Signed-off-by: Marat Radchenko --- git-compat-util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-compat-util.h b/git-compat-util.h index b338277..101c9d7 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -474,7 +474,7 @@ extern int git_munmap(void *start, size_

[PATCH 13/14] git-compat-util.h: fix integer overflow on IL32P64 systems

2014-09-30 Thread Marat Radchenko
Signed-off-by: Marat Radchenko --- git-compat-util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-compat-util.h b/git-compat-util.h index 9d2d5ab..5f6659c 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -474,7 +474,7 @@ extern int git_munmap(void *start, size_

[PATCH 13/14] git-compat-util.h: fix integer overflow on IL32P64 systems

2014-09-28 Thread Marat Radchenko
Signed-off-by: Marat Radchenko --- git-compat-util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-compat-util.h b/git-compat-util.h index 9d2d5ab..5f6659c 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -474,7 +474,7 @@ extern int git_munmap(void *start, size_