Re: [PATCH 12/41] builtin/update-index.c: use error_errno()

2016-05-02 Thread Duy Nguyen
On Mon, May 2, 2016 at 1:40 AM, Eric Sunshine wrote: > On Sun, May 1, 2016 at 7:14 AM, Nguyễn Thái Ngọc Duy > wrote: >> "err" is deleted because it just causes confusion when "errno" is also >> used directly in process_lstat_error(). > > Despite the function name which may imply that it is consu

Re: [PATCH 12/41] builtin/update-index.c: use error_errno()

2016-05-01 Thread Eric Sunshine
On Sun, May 1, 2016 at 7:14 AM, Nguyễn Thái Ngọc Duy wrote: > "err" is deleted because it just causes confusion when "errno" is also > used directly in process_lstat_error(). Despite the function name which may imply that it is consulting errno, this change makes me feel slightly uncomfortable si

[PATCH 12/41] builtin/update-index.c: use error_errno()

2016-05-01 Thread Nguyễn Thái Ngọc Duy
"err" is deleted because it just causes confusion when "errno" is also used directly in process_lstat_error(). Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/update-index.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/update-index.c b/builtin/update-index.