Re: [PATCH 11/53] fast-import: convert to struct object_id

2017-04-24 Thread brian m. carlson
On Mon, Apr 24, 2017 at 10:20:27AM -0700, Stefan Beller wrote: > On Sun, Apr 23, 2017 at 2:34 PM, brian m. carlson > wrote: > > Signed-off-by: brian m. carlson > > --- > > > @@ -2823,12 +2821,10 @@ static void parse_new_commit(const char *arg) > > strbuf_addf(&new_data, "tree %s\n", > >

Re: [PATCH 11/53] fast-import: convert to struct object_id

2017-04-24 Thread Stefan Beller
On Sun, Apr 23, 2017 at 2:34 PM, brian m. carlson wrote: > Convert the remaining parts of fast-import.c to use struct object_id. > Convert several instances of get_sha1_hex to parse_oid_hex to avoid > needing to specify constants. Convert other hardcoded values to named > constants. Finally, use

[PATCH 11/53] fast-import: convert to struct object_id

2017-04-23 Thread brian m. carlson
Convert the remaining parts of fast-import.c to use struct object_id. Convert several instances of get_sha1_hex to parse_oid_hex to avoid needing to specify constants. Convert other hardcoded values to named constants. Finally, use the is_empty_tree_oid function instead of a direct comparison aga