Re: [PATCH 11/19] pack-objects: use bitmaps when packing objects

2013-10-30 Thread Vicent Marti
On Wed, Oct 30, 2013 at 11:38 AM, Shawn Pearce wrote: >> Since (1) is relatively rare, I think we are using this as a proxy for >> (2), so that we can do a regular walk rather than looking around for >> bitmaps that don't exist. But I may be misremembering the reasoning. >> Vicent? > > Ah. I am no

Re: [PATCH 11/19] pack-objects: use bitmaps when packing objects

2013-10-30 Thread Shawn Pearce
On Wed, Oct 30, 2013 at 8:21 AM, Jeff King wrote: > On Fri, Oct 25, 2013 at 02:14:11PM +, Shawn O. Pearce wrote: >> On Thu, Oct 24, 2013 at 6:04 PM, Jeff King wrote: >> > For bitmaps to be used, the following must be true: >> > >> > 1. We must be packing to stdout (as a normal `pack-objects

Re: [PATCH 11/19] pack-objects: use bitmaps when packing objects

2013-10-30 Thread Jeff King
On Fri, Oct 25, 2013 at 02:14:11PM +, Shawn O. Pearce wrote: > On Thu, Oct 24, 2013 at 6:04 PM, Jeff King wrote: > > For bitmaps to be used, the following must be true: > > > > 1. We must be packing to stdout (as a normal `pack-objects` from > > `upload-pack` would do). > > > > 2. Th

Re: [PATCH 11/19] pack-objects: use bitmaps when packing objects

2013-10-25 Thread Shawn Pearce
On Thu, Oct 24, 2013 at 6:04 PM, Jeff King wrote: > For bitmaps to be used, the following must be true: > > 1. We must be packing to stdout (as a normal `pack-objects` from > `upload-pack` would do). > > 2. There must be a .bitmap index containing at least one of the > "have" objects

[PATCH 11/19] pack-objects: use bitmaps when packing objects

2013-10-24 Thread Jeff King
From: Vicent Marti In this patch, we use the bitmap API to perform the `Counting Objects` phase in pack-objects, rather than a traditional walk through the object graph. For a reasonably-packed large repo, the time to fetch and clone is often dominated by the full-object revision walk during the