Re: [PATCH 11/16] refs: move duplicate check to common code

2016-01-05 Thread David Turner
On Wed, 2015-12-23 at 07:27 +0100, Michael Haggerty wrote: > > +static int ref_update_reject_duplicates(struct ref_transaction > > *transaction, > > + struct string_list > > *refnames, > > + struct strbuf *err) > > I like that you

Re: [PATCH 11/16] refs: move duplicate check to common code

2015-12-22 Thread Michael Haggerty
On 12/03/2015 01:35 AM, David Turner wrote: > The check for duplicate refnames in a transaction is needed for > all backends, so move it to the common code. > > ref_transaction_commit_fn gains a new argument, the sorted > string_list of affected refnames. > > Signed-off-by: David Turner > --- >

[PATCH 11/16] refs: move duplicate check to common code

2015-12-02 Thread David Turner
The check for duplicate refnames in a transaction is needed for all backends, so move it to the common code. ref_transaction_commit_fn gains a new argument, the sorted string_list of affected refnames. Signed-off-by: David Turner --- refs.c | 71 +++