Re: [PATCH 10/75] diff.h: avoid bit fields in struct diff_flags

2019-01-09 Thread Stefan Beller
On Thu, Dec 27, 2018 at 8:26 AM Nguyễn Thái Ngọc Duy wrote: > > Bitfield addresses cannot be passed around in a pointer. This makes it > hard to use parse-options to set/unset them. Turn this struct to > normal integers. This of course increases the size of this struct > multiple times, but since

[PATCH 10/75] diff.h: avoid bit fields in struct diff_flags

2018-12-27 Thread Nguyễn Thái Ngọc Duy
Bitfield addresses cannot be passed around in a pointer. This makes it hard to use parse-options to set/unset them. Turn this struct to normal integers. This of course increases the size of this struct multiple times, but since we only have a handful of diff_options variables around, memory consump