Re: [PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter

2018-07-25 Thread Junio C Hamano
Eric Sunshine writes: > I did consider other approaches, such as a more generic option. For > example, --embed=range-diff:. I also considered supporting more > complex use-cases. For instance, git-range-diff itself accepts the two > ranges in several formats ("a..b c..d" or "x...z" or "i j k"), p

Re: [PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter

2018-07-25 Thread Eric Sunshine
On Wed, Jul 25, 2018 at 1:29 PM Junio C Hamano wrote: > A few random thoughts. > > * I find it somewhat disturbing that use of dash is inconsistent >between "--interdiff=" and "--range-diff=". I went with the common spellings we've seen on the mailing lists. "Interdiff", in particular, seems

Re: [PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter

2018-07-25 Thread Duy Nguyen
On Mon, Jul 23, 2018 at 9:59 PM Eric Sunshine wrote: > > On Mon, Jul 23, 2018 at 12:28 PM Duy Nguyen wrote: > > On Sun, Jul 22, 2018 at 11:58 AM Eric Sunshine > > wrote: > > > diff --git a/Documentation/git-format-patch.txt > > > b/Documentation/git-format-patch.txt > > > index f8a061794d..e7f

Re: [PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter

2018-07-25 Thread Junio C Hamano
Eric Sunshine writes: > On Mon, Jul 23, 2018 at 12:28 PM Duy Nguyen wrote: >> On Sun, Jul 22, 2018 at 11:58 AM Eric Sunshine >> wrote: >> > diff --git a/Documentation/git-format-patch.txt >> > b/Documentation/git-format-patch.txt >> > index f8a061794d..e7f404be3d 100644 >> > --- a/Documentati

Re: [PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter

2018-07-23 Thread Eric Sunshine
On Mon, Jul 23, 2018 at 12:28 PM Duy Nguyen wrote: > On Sun, Jul 22, 2018 at 11:58 AM Eric Sunshine > wrote: > > diff --git a/Documentation/git-format-patch.txt > > b/Documentation/git-format-patch.txt > > index f8a061794d..e7f404be3d 100644 > > --- a/Documentation/git-format-patch.txt > > +++

Re: [PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter

2018-07-23 Thread Duy Nguyen
On Sun, Jul 22, 2018 at 11:58 AM Eric Sunshine wrote: > diff --git a/Documentation/git-format-patch.txt > b/Documentation/git-format-patch.txt > index f8a061794d..e7f404be3d 100644 > --- a/Documentation/git-format-patch.txt > +++ b/Documentation/git-format-patch.txt > @@ -24,6 +24,7 @@ SYNOPSIS >

[PATCH 10/14] format-patch: add --range-diff option to embed diff in cover letter

2018-07-22 Thread Eric Sunshine
When submitting a revised version of a patch series, it can be helpful (to reviewers) to include a summary of changes since the previous attempt in the form of a range-diff, however, doing so involves manually copy/pasting the diff into the cover letter. Add a --range-diff option to automate this