Re: [PATCH 1/7] grep: don't redundantly compile throwaway patterns under threading

2017-05-12 Thread Ævar Arnfjörð Bjarmason
On Fri, May 12, 2017 at 7:35 PM, Brandon Williams wrote: > On 05/11, Ęvar Arnfjörš Bjarmason wrote: >> Change the pattern compilation logic under threading so that grep >> doesn't compile a pattern it never ends up using on the non-threaded >> code path, only to compile it again N times for N thre

Re: [PATCH 1/7] grep: don't redundantly compile throwaway patterns under threading

2017-05-12 Thread Brandon Williams
On 05/11, Ævar Arnfjörð Bjarmason wrote: > Change the pattern compilation logic under threading so that grep > doesn't compile a pattern it never ends up using on the non-threaded > code path, only to compile it again N times for N threads which will > each use their own copy, ignoring the initiall

[PATCH 1/7] grep: don't redundantly compile throwaway patterns under threading

2017-05-11 Thread Ævar Arnfjörð Bjarmason
Change the pattern compilation logic under threading so that grep doesn't compile a pattern it never ends up using on the non-threaded code path, only to compile it again N times for N threads which will each use their own copy, ignoring the initially compiled pattern. This redundant compilation d