Re: [PATCH 1/7] config.c: fix accuracy of line number in errors

2014-07-24 Thread Matthieu Moy
Tanay Abhra writes: > On 7/25/2014 12:01 AM, Junio C Hamano wrote: >> Tanay Abhra writes: >> >>> On 7/24/2014 3:19 AM, Junio C Hamano wrote: Tanay Abhra writes: > If a callback returns a negative value to `git_config*()` family, > they call `die()` while printing the line num

Re: [PATCH 1/7] config.c: fix accuracy of line number in errors

2014-07-24 Thread Tanay Abhra
On 7/25/2014 12:01 AM, Junio C Hamano wrote: > Tanay Abhra writes: > >> On 7/24/2014 3:19 AM, Junio C Hamano wrote: >>> Tanay Abhra writes: >>> If a callback returns a negative value to `git_config*()` family, they call `die()` while printing the line number and the file name. C

Re: [PATCH 1/7] config.c: fix accuracy of line number in errors

2014-07-24 Thread Junio C Hamano
Tanay Abhra writes: > On 7/24/2014 3:19 AM, Junio C Hamano wrote: >> Tanay Abhra writes: >> >>> If a callback returns a negative value to `git_config*()` family, >>> they call `die()` while printing the line number and the file name. >>> Currently the printed line number is off by one, thus pri

Re: [PATCH 1/7] config.c: fix accuracy of line number in errors

2014-07-24 Thread Tanay Abhra
On 7/24/2014 3:19 AM, Junio C Hamano wrote: > Tanay Abhra writes: > >> If a callback returns a negative value to `git_config*()` family, >> they call `die()` while printing the line number and the file name. >> Currently the printed line number is off by one, thus printing the >> wrong line num

Re: [PATCH 1/7] config.c: fix accuracy of line number in errors

2014-07-23 Thread Junio C Hamano
Tanay Abhra writes: > If a callback returns a negative value to `git_config*()` family, > they call `die()` while printing the line number and the file name. > Currently the printed line number is off by one, thus printing the > wrong line number. > > Make `linenr` point to the line we just parse

[PATCH 1/7] config.c: fix accuracy of line number in errors

2014-07-23 Thread Tanay Abhra
If a callback returns a negative value to `git_config*()` family, they call `die()` while printing the line number and the file name. Currently the printed line number is off by one, thus printing the wrong line number. Make `linenr` point to the line we just parsed during the call to callback to