Re: [PATCH 1/7] cache_or_unpack_entry: drop keep_cache parameter

2016-08-23 Thread Junio C Hamano
Jeff King writes: > There is only one caller of cache_or_unpack_entry() and it > always passes 1 for the keep_cache parameter. We can > simplify it by dropping the "!keep_cache" case. > > Another call, which did pass 0, was dropped in abe601b > (sha1_file: remove recursion in unpack_entry, 2013-0

[PATCH 1/7] cache_or_unpack_entry: drop keep_cache parameter

2016-08-22 Thread Jeff King
There is only one caller of cache_or_unpack_entry() and it always passes 1 for the keep_cache parameter. We can simplify it by dropping the "!keep_cache" case. Another call, which did pass 0, was dropped in abe601b (sha1_file: remove recursion in unpack_entry, 2013-03-27), as unpack_entry() now do