Re: [PATCH 1/6] t1450: clean up sub-objects in duplicate-entry test

2017-01-17 Thread Jeff King
On Tue, Jan 17, 2017 at 12:52:43PM -0800, Junio C Hamano wrote: > > Since the setup code happens inside a subshell, we can't > > just set a variable for each object. However, we can stuff > > all of the sha1s into the $T output variable, which is not > > used for anything except cleanup. > > > > S

Re: [PATCH 1/6] t1450: clean up sub-objects in duplicate-entry test

2017-01-17 Thread Junio C Hamano
Jeff King writes: > This test creates a multi-level set of trees, but its > cleanup routine only removes the top-level tree. After the > test finishes, the inner tree and the blob it points to > remain, making the inner tree dangling. > > A later test ("cleaned up") verifies that we've removed an

[PATCH 1/6] t1450: clean up sub-objects in duplicate-entry test

2017-01-16 Thread Jeff King
This test creates a multi-level set of trees, but its cleanup routine only removes the top-level tree. After the test finishes, the inner tree and the blob it points to remain, making the inner tree dangling. A later test ("cleaned up") verifies that we've removed any cruft and "git fsck" output i