Re: [PATCH 1/5] git-compat-util: add xstrdup_or_null helper

On Mon, Jan 12, 2015 at 06:21:19PM -0800, Jonathan Nieder wrote: > Jeff King wrote: > > > --- a/git-compat-util.h > > +++ b/git-compat-util.h > > @@ -675,6 +675,11 @@ extern char *xgetcwd(void); > > > > #define REALLOC_ARRAY(x, alloc) (x) = xrealloc((x), (alloc) * sizeof(*(x))) > > > > +stat

Re: [PATCH 1/5] git-compat-util: add xstrdup_or_null helper

Jeff King wrote: > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -675,6 +675,11 @@ extern char *xgetcwd(void); > > #define REALLOC_ARRAY(x, alloc) (x) = xrealloc((x), (alloc) * sizeof(*(x))) > > +static inline char *xstrdup_or_null(const char *str) > +{ > + return str ? xstrdup(s

[PATCH 1/5] git-compat-util: add xstrdup_or_null helper

It's a common idiom to duplicate a string if it is non-NULL, or pass a literal NULL through. This is already a one-liner in C, but you do have to repeat the name of the string twice. So if there's a function call, you must write: const char *x = some_fun(...); return x ? xstrdup(x) : NULL; in