Re: [PATCH 1/5] check-ref-format: Refactor out check_one_ref_format

2016-12-19 Thread Michael Haggerty
On 12/19/2016 02:19 PM, Ian Jackson wrote: > Michael Haggerty writes ("Re: [PATCH 1/5] check-ref-format: Refactor out > check_one_ref_format"): >> On 11/04/2016 08:13 PM, Ian Jackson wrote: >>> +static int check_one_ref_format(const char *refname) > ... >>

Re: [PATCH 1/5] check-ref-format: Refactor out check_one_ref_format

2016-12-19 Thread Ian Jackson
Michael Haggerty writes ("Re: [PATCH 1/5] check-ref-format: Refactor out check_one_ref_format"): > On 11/04/2016 08:13 PM, Ian Jackson wrote: > > +static int check_one_ref_format(const char *refname) ... > This function needs to `return 0` if it gets to the end. Indeed

Re: [PATCH 1/5] check-ref-format: Refactor out check_one_ref_format

2016-12-19 Thread Michael Haggerty
On 11/04/2016 08:13 PM, Ian Jackson wrote: > We are going to want to reuse this. No functional change right now. > > It currently has a hidden memory leak if --normalize is used. > > Signed-off-by: Ian Jackson > --- > builtin/check-ref-format.c | 26 ++ > 1 file changed

[PATCH 1/5] check-ref-format: Refactor out check_one_ref_format

2016-11-04 Thread Ian Jackson
We are going to want to reuse this. No functional change right now. It currently has a hidden memory leak if --normalize is used. Signed-off-by: Ian Jackson --- builtin/check-ref-format.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/builtin/c