Re: [PATCH 1/4] t0021: use write_script to create rot13 shell script

> On 06 Nov 2016, at 15:29, Jeff King wrote: > > On Sun, Nov 06, 2016 at 03:25:33PM +0100, Lars Schneider wrote: > >> This looks good to me (and it works on my machine). >> However, I took a look at the "write_script" function and found this, >> added by Junio in 840c519d: >> >> echo "#!${2-"$

Re: [PATCH 1/4] t0021: use write_script to create rot13 shell script

On Sun, Nov 06, 2016 at 03:25:33PM +0100, Lars Schneider wrote: > This looks good to me (and it works on my machine). > However, I took a look at the "write_script" function and found this, > added by Junio in 840c519d: > > echo "#!${2-"$SHELL_PATH"}" && > > There is some kind of variable expans

Re: [PATCH 1/4] t0021: use write_script to create rot13 shell script

> On 02 Nov 2016, at 19:17, Jeff King wrote: > > This avoids us fooling around with $SHELL_PATH and the > executable bit ourselves. > > Signed-off-by: Jeff King > --- > t/t0021-conversion.sh | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/t/t0021-conversion.sh b/t/t

[PATCH 1/4] t0021: use write_script to create rot13 shell script

This avoids us fooling around with $SHELL_PATH and the executable bit ourselves. Signed-off-by: Jeff King --- t/t0021-conversion.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh index a20b9f58e..dfde22549 100755 --- a/t/t0021