Re: [PATCH 1/4] submodule: refuse to add repository with no commits

2019-03-16 Thread Kyle Meyer
Kyle Meyer writes: [...] > diff --git a/git-submodule.sh b/git-submodule.sh > index 514ede2596..6c74656027 100755 > --- a/git-submodule.sh > +++ b/git-submodule.sh > @@ -234,10 +234,18 @@ cmd_add() > if test -z "$force" && > ! git add --dry-run --ignore-missing --no-warn-embe

[PATCH 1/4] submodule: refuse to add repository with no commits

2019-03-14 Thread Kyle Meyer
When the path given to 'git submodule add' is an existing repository that is not in the index, the repository is passed to 'git add'. If this repository doesn't have any commits, we don't get a useful result: there is no subproject OID to track, and any untracked files in the sub-repository are ad