David Aguilar writes:
> Definitely. I learned this the hard way when the tests broke on me while
> working it ;-) My patch rewrites things to always use var=$(command)
> expressions with separate test "$var" evaluating them.
OK; that wasn't clear from the log message.
--
To unsubscribe from t
David Aguilar writes:
> Use $(command "$arg") instead of "$(command "$arg")" as the latter is
> harder to read.
Did you miss my comment that this is about RHS of an assignment?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
On Sun, Jan 27, 2013 at 2:08 PM, Johannes Sixt wrote:
> Am 27.01.2013 22:24, schrieb David Aguilar:
>> Use $(command "$arg") instead of "$(command "$arg")" as the latter is
>> harder to read.
>
> If at all, you should restrict yourself to simplify only variable
> assignments. Because this case:
>
Am 27.01.2013 22:24, schrieb David Aguilar:
> Use $(command "$arg") instead of "$(command "$arg")" as the latter is
> harder to read.
If at all, you should restrict yourself to simplify only variable
assignments. Because this case:
> - if test -z "$(get_merge_tool_cmd "$merge_tool")" &&
> +
Use $(command "$arg") instead of "$(command "$arg")" as the latter is
harder to read. Make the expression in get_merge_tool_cmd() even
simpler by avoiding "echo" completely.
Signed-off-by: David Aguilar
---
git-mergetool--lib.sh | 40
1 file changed, 16
5 matches
Mail list logo
