Re: [PATCH 1/4] hooks: Add function to check if a hook exists

2012-12-29 Thread Junio C Hamano
Aaron Schrab writes: > Since I'm going to be changing the interface for this hook in v2 of > the series so that it will be more complicated than can be readily > addressed with the run_hook() API (and will have use a fixed number of > arguments anyway) I'll be dropping the run_hook_argv() functio

Re: [PATCH 1/4] hooks: Add function to check if a hook exists

2012-12-29 Thread Aaron Schrab
At 18:08 -0800 28 Dec 2012, Junio C Hamano wrote: Aaron Schrab writes: Create find_hook() function to determine if a given hook exists and is executable. If it is the path to the script will be returned, otherwise NULL is returned. Sounds like a sensible thing to do. To make sure the API

Re: [PATCH 1/4] hooks: Add function to check if a hook exists

2012-12-28 Thread Junio C Hamano
Aaron Schrab writes: > Create find_hook() function to determine if a given hook exists and is > executable. If it is the path to the script will be returned, otherwise > NULL is returned. Sounds like a sensible thing to do. To make sure the API is also sensible, all the existing hooks should b

[PATCH 1/4] hooks: Add function to check if a hook exists

2012-12-28 Thread Aaron Schrab
Create find_hook() function to determine if a given hook exists and is executable. If it is the path to the script will be returned, otherwise NULL is returned. This is in support for an upcoming run_hook_argv() function which will expect the full path to the hook script as the first element in t