Re: [PATCH 1/4] Introduce a function to lock/unlock file descriptors when appending

2018-08-10 Thread Johannes Schindelin
Hi Junio, On Thu, 9 Aug 2018, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > This function will be used to make write accesses in trace_write() a bit > > safer. > > ... > > To set a precedent for a better approach, let's introdu

Re: [PATCH 1/4] Introduce a function to lock/unlock file descriptors when appending

2018-08-09 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > This function will be used to make write accesses in trace_write() a bit > safer. > ... > To set a precedent for a better approach, let's introduce a proper > abstraction: a function that says in its name precisely wh

[PATCH 1/4] Introduce a function to lock/unlock file descriptors when appending

2018-08-09 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin This function will be used to make write accesses in trace_write() a bit safer. Note: this patch takes a very different approach for cross-platform support than Git is historically taking: the original approach is to first implement everything on Linux, using the functi