Junio C Hamano wrote:
> "Michael G. Schwern" writes:
> > +# Note: not certain why this is in use instead of die. Probably because
> > +# the exit code of die is 255? Doesn't appear to be used consistently.
Yes, 255 caused problems for the test suite:
commit d25c26e771fdf771f264dc85be348719886
On 2012.7.26 10:18 PM, Junio C Hamano wrote:
>> +# Note: not certain why this is in use instead of die. Probably because
>> +# the exit code of die is 255? Doesn't appear to be used consistently.
>> +sub fatal (@) { print STDERR "@_\n"; exit 1 }
>
> Very true. Also I do not think the line-noise
"Michael G. Schwern" writes:
> From: "Michael G. Schwern"
>
> Put them in a new module called Git::SVN::Utils. Yeah, not terribly
> original and it will be a dumping ground. But its better than having
> them in the main git-svn program. At least they can be documented
> and tested.
>
> * fata
From: "Michael G. Schwern"
Put them in a new module called Git::SVN::Utils. Yeah, not terribly
original and it will be a dumping ground. But its better than having
them in the main git-svn program. At least they can be documented
and tested.
* fatal() is used by many classes.
* Change the $ca
Michael G Schwern wrote:
> This is rapidly getting into the weeds. Regardless of the debate below, what
> would you like me to do? Switch indentation to tabs and resubmit? AFAIK only
> the new tests are affected.
Yes, please do so at some point before the final submission. (If
there's more fe
Michael G Schwern wrote:
> This is rapidly getting into the weeds. Regardless of the debate below, what
> would you like me to do? Switch indentation to tabs and resubmit? AFAIK only
> the new tests are affected.
Yes, unless Jonathan (or anybody else) has more comments.
> On 2012.7.25 4:08 PM
This is rapidly getting into the weeds. Regardless of the debate below, what
would you like me to do? Switch indentation to tabs and resubmit? AFAIK only
the new tests are affected.
On 2012.7.25 4:08 PM, Eric Wong wrote:
+BEGIN {
+# Override exit at BEGIN time before Git::SVN::Ut
Michael G Schwern wrote:
> On 2012.7.25 2:24 PM, Eric Wong wrote:
> > Didn't we agree to use done_testing()? Perhaps (as you suggested) with
> > a private copy of Test::More? It's probably easier to start using
> > done_testing() earlier rather than later.
>
> Yes, we agreed done_testing is th
On 2012.7.25 2:24 PM, Eric Wong wrote:
> Please keep Jonathan Cc:-ed, he's been very helpful with this series
> (and very helpful in general :)
I will try.
>> +use Test::More 'no_plan';
>
> Didn't we agree to use done_testing()? Perhaps (as you suggested) with
> a private copy of Test::More?
"Michael G. Schwern" wrote:
> From: "Michael G. Schwern"
>
> Put them in a new module called Git::SVN::Utils. Yeah, not terribly
> original and it will be a dumping ground. But its better than having
> them in the main git-svn program. At least they can be documented
> and tested.
>
> * fata
From: "Michael G. Schwern"
Put them in a new module called Git::SVN::Utils. Yeah, not terribly
original and it will be a dumping ground. But its better than having
them in the main git-svn program. At least they can be documented
and tested.
* fatal() is used by many classes.
* Change the $ca
11 matches
Mail list logo
