Re: [PATCH 1/4] Accept commit in some places when tree is needed.

2005-04-20 Thread Linus Torvalds
On Tue, 19 Apr 2005, Junio C Hamano wrote: > > This patch lifts the tree-from-tree-or-commit logic from > diff-cache.c and moves it to sha1_file.c, which is a common > library source for the SHA1 storage part. I don't think that's a good interface. It changes the sha1 passed into it: that may

(fixed) [PATCH 1/4] Accept commit in some places when tree is needed.

2005-04-19 Thread Junio C Hamano
_BLUSH_ The 1/4 in the series was a buggy one I sent by mistake. Please replace it with this fixed one. The other three are OK. BTW, do you have a preferred patch-mail convention to mark the cover paragraph like this to be excluded from the commit log, like the three-dash one you mentioned t

[PATCH 1/4] Accept commit in some places when tree is needed.

2005-04-19 Thread Junio C Hamano
Similar to the diff-cache command, we should accept commit ID when tree ID is required but the end-user intent is unambiguous. This patch lifts the tree-from-tree-or-commit logic from diff-cache.c and moves it to sha1_file.c, which is a common library source for the SHA1 storage part. Signed-off-