Re: [PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-30 Thread Ramsay Jones
Junio C Hamano wrote: > Erik Faye-Lund writes: > >> On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones >> wrote: >>> >>> The getline() function is a GNU extension (you need to define >>> _GNU_SOURCE before including stdio.h) and is, therefore, not >>> portable. In particular, getline() is not availab

Re: [PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-30 Thread Ramsay Jones
Erik Faye-Lund wrote: > On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones > wrote: >> >> The getline() function is a GNU extension (you need to define >> _GNU_SOURCE before including stdio.h) and is, therefore, not >> portable. In particular, getline() is not available on MinGW. > > Actually, getline

Re: [PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-26 Thread Junio C Hamano
Erik Faye-Lund writes: > On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones > wrote: >> >> The getline() function is a GNU extension (you need to define >> _GNU_SOURCE before including stdio.h) and is, therefore, not >> portable. In particular, getline() is not available on MinGW. > > Actually, getli

Re: [PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-25 Thread Erik Faye-Lund
On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones wrote: > > The getline() function is a GNU extension (you need to define > _GNU_SOURCE before including stdio.h) and is, therefore, not > portable. In particular, getline() is not available on MinGW. Actually, getline is a POSIX-2008 feature, so it's

Re: [PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-25 Thread Joachim Schmitz
Ramsay Jones wrote: The getline() function is a GNU extension (you need to define _GNU_SOURCE before including stdio.h) and is, therefore, not portable. In particular, getline() is not available on MinGW. In order to support non-GNU systems, we replace the call to getline() with (almost) equival

[PATCH 1/3] remote-testsvn.c: Avoid the getline() GNU extension function

2012-08-25 Thread Ramsay Jones
The getline() function is a GNU extension (you need to define _GNU_SOURCE before including stdio.h) and is, therefore, not portable. In particular, getline() is not available on MinGW. In order to support non-GNU systems, we replace the call to getline() with (almost) equivalent code using strbuf