Re: [PATCH 1/3] gettext: avoid initialization if the locale dir is not present

2018-04-21 Thread Johannes Schindelin
Hi Ævar, On Sat, 21 Apr 2018, Ævar Arnfjörð Bjarmason wrote: > I still stand by the observation that the "why don't we" isn't clear at > all from your patch's commit message and that should be fixed. It > doesn't mention any of the actual reasons for the change which have been > revealed in this

Re: [PATCH 1/3] gettext: avoid initialization if the locale dir is not present

2018-04-21 Thread Ævar Arnfjörð Bjarmason
On Fri, Apr 20 2018, Johannes Schindelin wrote: > Hi Ævar, > > On Fri, 20 Apr 2018, Ævar Arnfjörð Bjarmason wrote: > >> On Fri, Apr 20 2018, Martin Ågren wrote: >> >> > On 20 April 2018 at 11:59, Ævar Arnfjörð Bjarmason >> > wrote: >> >> >> >> On Fri, Apr 20 2018, Johannes Schindelin wrote: >>

Re: [PATCH 1/3] gettext: avoid initialization if the locale dir is not present

2018-04-20 Thread Johannes Schindelin
Hi Ævar, On Fri, 20 Apr 2018, Ævar Arnfjörð Bjarmason wrote: > On Fri, Apr 20 2018, Martin Ågren wrote: > > > On 20 April 2018 at 11:59, Ævar Arnfjörð Bjarmason wrote: > >> > >> On Fri, Apr 20 2018, Johannes Schindelin wrote: > >> > >>> The runtime of a simple `git.exe version` call on Windows

Re: [PATCH 1/3] gettext: avoid initialization if the locale dir is not present

2018-04-20 Thread Ævar Arnfjörð Bjarmason
On Fri, Apr 20 2018, Martin Ågren wrote: > On 20 April 2018 at 11:59, Ævar Arnfjörð Bjarmason wrote: >> >> On Fri, Apr 20 2018, Johannes Schindelin wrote: >> >>> The runtime of a simple `git.exe version` call on Windows is currently >>> dominated by the gettext setup, adding a whopping ~150ms to

Re: [PATCH 1/3] gettext: avoid initialization if the locale dir is not present

2018-04-20 Thread Martin Ågren
On 20 April 2018 at 11:59, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Apr 20 2018, Johannes Schindelin wrote: > >> The runtime of a simple `git.exe version` call on Windows is currently >> dominated by the gettext setup, adding a whopping ~150ms to the ~210ms >> total. >> >> Given that this cost i

Re: [PATCH 1/3] gettext: avoid initialization if the locale dir is not present

2018-04-20 Thread Ævar Arnfjörð Bjarmason
On Fri, Apr 20 2018, Johannes Schindelin wrote: > The runtime of a simple `git.exe version` call on Windows is currently > dominated by the gettext setup, adding a whopping ~150ms to the ~210ms > total. > > Given that this cost is added to each and every git.exe invocation goes > through common-m

[PATCH 1/3] gettext: avoid initialization if the locale dir is not present

2018-04-20 Thread Johannes Schindelin
The runtime of a simple `git.exe version` call on Windows is currently dominated by the gettext setup, adding a whopping ~150ms to the ~210ms total. Given that this cost is added to each and every git.exe invocation goes through common-main's invocation of git_setup_gettext(), and given that scrip