Re: [PATCH 1/3] commit-graph: remove a duplicate assignment

2019-09-26 Thread Alex Henrie
On Thu, Sep 26, 2019 at 7:02 AM Derrick Stolee wrote: > > Could we instead remove the assignment during the declaration? It is > easier to know the while loop will work if the assignment is closer > to the loop. Sure, that's fine. I'll send a v2 with that change. -Alex

Re: [PATCH 1/3] commit-graph: remove a duplicate assignment

2019-09-26 Thread Derrick Stolee
On 9/24/2019 10:01 PM, Alex Henrie wrote: > Signed-off-by: Alex Henrie > --- > commit-graph.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/commit-graph.c b/commit-graph.c > index 9b02d2c426..659f4bb4f4 100644 > --- a/commit-graph.c > +++ b/commit-graph.c > @@ -1534,7 +1534,6 @@ static

[PATCH 1/3] commit-graph: remove a duplicate assignment

2019-09-24 Thread Alex Henrie
Signed-off-by: Alex Henrie --- commit-graph.c | 1 - 1 file changed, 1 deletion(-) diff --git a/commit-graph.c b/commit-graph.c index 9b02d2c426..659f4bb4f4 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1534,7 +1534,6 @@ static void split_graph_merge_strategy(struct write_commit_graph_co