Re: [PATCH 1/3] clone: use a more appropriate variable name for the default refspec

2018-11-15 Thread Jeff King
On Wed, Nov 14, 2018 at 11:46:18AM +0100, SZEDER Gábor wrote: > cmd_clone() declares two strbufs 'key' and 'value' on the same line, > suggesting that they are used to contruct a config variable's name and > value. However, this is not the case: 'key' is used to construct the > names of multiple

[PATCH 1/3] clone: use a more appropriate variable name for the default refspec

2018-11-14 Thread SZEDER Gábor
cmd_clone() declares two strbufs 'key' and 'value' on the same line, suggesting that they are used to contruct a config variable's name and value. However, this is not the case: 'key' is used to construct the names of multiple config variables, while 'value' is never used as a value for any of tho